Bump Optimization to v4, and related packages accordingly #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing test MWE using Random
using Turing
import ReverseDiff
@model function f()
x ~ Normal(0, 1)
end
Random.seed!(222)
# cons_args is mandatory, if no constraints are passed it runs fine
cons(res, x, _) = (res .= [x[1]])
cons_args = (cons=cons, lcons=[0], ucons=[Inf])
initial_params = [0.5]
m1 = Turing.Optimisation.estimate_mode(
f(), MAP(); initial_params=initial_params, cons_args...
)Show the error tracebackOutput of ]st --manifestversioninfo() |
penelopeysm
force-pushed
the
ch-optimization4
branch
from
a504d0f to
3c91eec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2354 +/- ##
==========================================
- Coverage 86.39% 86.26% -0.13%
==========================================
Files 22 22
Lines 1573 1573
==========================================
- Hits 1359 1357 -2
- Misses 214 216 +2 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11073388637Details
💛 - Coveralls |
|
This method ambiguity is fixed in JuliaDiff/ForwardDiff.jl#687, it just needs a release |
|
I think bumping Optimization to v4 (which in turn bumps OptimizationBase to v2) would also allow it to work with Mooncake as an AD backend (since it now goes via DifferentiationInterface, SciML/OptimizationBase.jl#108). Both the MLE and MAP tests pass with Optimization@4 and adtype=AutoMooncake. |
2 tasks
|
Maybe mark ForwardDiff-related tests as broken and get this merged? |
|
@yebai can do! |
|
It's curious, but the ForwardDiff tests that were failing previously seem to have been fixed on Julia 1.11. These were the previous failures: https://github.com/TuringLang/Turing.jl/actions/runs/11072371830/job/30766467971 This was pre-1.11 so the CI was running on 1.10.5. In contrast, none of those tests fail here: https://github.com/TuringLang/Turing.jl/actions/runs/11483911558/job/31960475967 The only failure here is because Mooncake was marked as broken, which it isn't. The method that was ambiguous was |
|
The remaining test failure is #2371. I could rerun CI to get the green tick, but don't see much of a point. |
|
Feel free to merge. |
|
CI passed on the main branch after we merged 😄 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opening #2327.
Closes #2348
Closes #2349
Closes #2350
Closes #2351
Closes #2352
Closes #2353